Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] configure users and metadata storage separately #2598

Merged
merged 2 commits into from
Oct 11, 2021
Merged

[full-ci] configure users and metadata storage separately #2598

merged 2 commits into from
Oct 11, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 8, 2021

Description

User and metadata storage on oCIS storage used the same path after oCIS 1.12.0. This needs to be fixed for a oCIS 1.13.0 release.
Therefore we split up the configuration of the user and metadata storage.

Related Issue

Motivation and Context

Solve it once and forever.

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@wkloucek wkloucek changed the title configure users and metadata storage separately [full-ci] configure users and metadata storage separately Oct 8, 2021
@butonic
Copy link
Member

butonic commented Oct 8, 2021

I was hoping to reuse some of the driver configuration structs but apparently that makes things even more fragile. I'm still not happy with the whole reva config but also currently see no better way then to introduce a separate set of config flags.

to fix the tests try adding an rm for the metadata driver to the DELETE_USER_DATA_CMD="rm -rf /var/tmp/reva/data/nodes/root/* /var/tmp/reva/data/nodes/*-*-*-* /var/tmp/reva/data/blobs/*" ... hm where is that? reva uses it for the integration tests in the .drone.star 🤔

@wkloucek
Copy link
Contributor Author

shares are broken, the receiver doesn't see the incoming share and the log has following message:

2021-10-11T08:32:52+02:00 ERR Path() error="Decomposedfs: root has no parent" node=null path=4c510ada-c86b-4815-8820-42cdf82c3d51/foo/file_example_PPT_1MB.pptx pkg=rgrpc service=storage
2021-10-11T08:32:52+02:00 ERR ../../../../go/pkg/mod/github.com/cs3org/reva@v1.13.1-0.20211006080436-67f39be571fa/internal/grpc/services/storageprovider/storageprovider.go:629 > error stating: resource_id:<storage_id:"1284d238-aa92-42ce-bdc4-0b0000009157" opaque_id:"941b9f33-807b-4104-8135-af55835986d7" >  error="Decomposedfs: root has no parent" pkg=rgrpc service=storage

@butonic do you have an idea?

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
14.3% 14.3% Duplication

@wkloucek wkloucek requested review from refs, butonic and C0rby and removed request for phil-davis and individual-it October 11, 2021 10:28
@wkloucek wkloucek mentioned this pull request Oct 11, 2021
Closed
24 tasks
@wkloucek wkloucek merged commit 0d4bc30 into master Oct 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_metadata_storage branch October 11, 2021 11:06
ownclouders pushed a commit that referenced this pull request Oct 11, 2021
@wkloucek
commit 0d4bc30
829ee8f 
Merge: 1ee4198 6c6cb64
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Oct 11 13:06:17 2021 +0200

    Merge pull request #2598 from owncloud/fix_metadata_storage

    [full-ci] configure users and metadata storage separately
AndreasSko added a commit to AndreasSko/infrastructure that referenced this pull request Oct 17, 2021
@AndreasSko
OCIS: Update to new S3NG flags
02776e5 
With owncloud/ocis#2598 the flags for the S3NG driver were updated.
wkloucek added a commit to owncloud/web that referenced this pull request Oct 20, 2021
@wkloucek
adapt to changed vars from owncloud/ocis#2598 and don't override data…
327663f 
…gateway address because of owncloud/ocis#2612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@micbar micbar micbar approved these changes

@refs refs Awaiting requested review from refs

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wkloucek @ownclouders @butonic @micbar @C0rby